Trade

Thank you

 

@Calytic @Wulf
bug with absence of checking OnItemSplit - users can fool each other just dropping out one by one (right-click out of the box) items from thier trade box, just giving only 1 item in stack instead of shown in trade window

 

Ive been using the plugin for a few days and it works really well, I like it!

My only concern, is that Im worried it can be abused between friends/clan members to freely transfer items and raiding materials across the map, ex:
- Player A is holding 10 c4, Player B runs over to base to attack, once Player B gets there they do a trade and the 10 c4 is transferred, Player B never has to risk holding the C4 on them while running
or
- Player A is out farming, instead of running back to base, Player A trades with clan member/friend Player B who is in the base, and transfers all collected resources to him, and Player A can keep farming without having to run back to base

Potential Solutions
- tie to Economy plugin and require currency cost to perform trade transaction (so it wont be free to trade, costs money)

Ill let you know if I come up with any more ideas!

 

im having problems granting access on my server can someone help me with the commands to grant access to trade

 

In your console run these commands:
grant group default trade.use
grant group default trade.accept

 

doesnt work with the latest rust update

 

not that i noticed, the thing that is broke is the UI part of the trade menu which i guess has something to do with the CUI beig broke?

 

any idea when it will be fixed?

 

well, i will keep an eye out for the updates

 

Code:

(20:50:16) | 178.34.158.80:52150/76561198195834047/Twenty One pillot disconnecting: RPC Error in AddUI
(20:50:16) | 91.243.199.247:57198/76561198323558681////Your_Terror\\\\ disconnecting: RPC Error in AddUI
(20:52:30) | 178.34.158.80:47541/76561198195834047/Twenty One pillot disconnecting: RPC Error in AddUI
(20:52:30) | 91.243.199.247:57340/76561198323558681////Your_Terror\\\\ disconnecting: RPC Error in AddUI

 

Hi, have a suggestion for multiple players having the same name, i.e. John and JohnDoe, NTeleportation and PrivateMessage have implemented a SteamID workaround, could the same be done for Trade? Whereas /tpr 76561198043848711 and /pm 76561198043848711 work great, could we please have another way to trade those with same-names: /trade 76561198043848711 ?

 

Using steamid's instead of a name is part of the PlayerFinding function in Oxide, you give the function a name/steamid and it'll return the details if they exist. Looking into the plugin they're using their own player finding function, however making use of the oxide function would be a good idea for the plugin dev

 

Plugin has a bug if you put item and accept but other party wont accept and you press Tab to close inventory you will lose all you items which you wanted to trade

 

Plugin should check if player can trade (i mean CanPlayerTrade()) somewhere at the StartTrades() method, because otherwise this plugin can be abused with different plugins to get free items, etc.

 

Still getting these errors.

Code:

(09:38:17) | Failed to call hook 'CanNetworkTo' on plugin 'Trade v1.1.1' (NullReferenceException: Object reference not set to an instance of an object)
(09:38:17) | at Oxide.Plugins.Trade.IsTradeBox (.BaseNetworkable entity) [0x00000] in <filename unknown>:0
  at Oxide.Plugins.Trade.CanNetworkTo (.BaseNetworkable entity, .BasePlayer target) [0x00000] in <filename unknown>:0
  at Oxide.Plugins.Trade.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00000] in <filename unknown>:0
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (HookMethod method, System.Object[] args) [0x00000] in <filename unknown>:0
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x00000] in <filename unknown>:0
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00000] in <filename unknown>:0

 

can you please change from standart box to "assets/prefabs/building/wall.frame.shopfront/wall.frame.shopfront.metal.prefab"
It will be easier an beautifully !
[DOUBLEPOST=1495563084][/DOUBLEPOST]And add config string to change box name, its takes here