HeliControl

Hey Shady,

I can definitely confirm that the Helicontrol plugin is triggering the server crashes. The server crashes either the moment the Helicopter is downed and spawns crates OR the moment the last spawned item is looted (crate or copter). While this doesn't happen every time it's about 1 in 3 when this plugin is active.

We experienced this, this morning at 7:11am EST when specifically testing for it. Once the plugin was removed we could spawn and loot 10+ heli's no problem.

I would specifically look at what happens concerning your plugin when a helicopter is downed, and when the final item is looted. Does your timer start again when the last piece of loot is looted?

 

Do you have napalm disabled in your config? If so try re-enabling it. Leaving it enabled fixed the issue for me.

 

Here's my config so there are no questions. I'll upload my log in a moment.
[DOUBLEPOST=1483287319][/DOUBLEPOST]An odd question... would HeliControl and Alphaloot be fighting when the last crate is looted since I don't have "Use Custom loot Spawns" set to true?
[DOUBLEPOST=1483288032][/DOUBLEPOST]I cleaned up the log a bit by removing the "UnityEngineDebugBindings.gen.cpp Line: 42)" entry. This is what happens every time. Please note that the helicopter is down and everytime they loot a crate, or finish looting the patrol helicopter it says "The Patrol Helicopter was taken down".

 

I have the time for unlocking crates set to 0.0, instead of -1.0. There are two parameters in the config set at -1, which I don't get. I'm not saying this is your issue, but I had to start with a unchanged cfg file and make one change at a time until I found what was causing my problem. It turned out to be the napalm, but yours is enabled, so your situation appears to be different. I have attached my cfg. It works on my server with no crashes. It is set so that there is no bullet/rocket damage and the gibs can be immediately harvested, after you wait out the fires. I have the amount of water to put out the flames set to 500, which equates to two full bota bags per fire. You can change as you see fit, but I recommend doing one change at a time and then calling a heli and testing it out. Otherwise I will allow the plugin dev to look into the issue.

Oh and I do use Custom Loot Spawns but not for the heli. It is set to false.

 

I'm pretty sure anyone who is experiencing crashes right now is not related to HeliControl. It does seem odd that Codepwned says his issue is resolved when the plugin is removed, because others say the opposite. Right now I think there may be two different bugs causing server crashes, hard to really tell, and even more difficult for me since I'm not experiencing them.

Following this thread: Server crashing periodically after last Rust update | Oxide - It seems like there's a bunch of mixed errors causing the crashes, so for now all I can really advise is to post the error from "output_log.txt" in that thread or wait for the next update, I'm very confident it's just a Rust issue.

To clarify, -1 means it's not modified, and left at the default value.

 

Thanks for the clarification, Shady.

 

Just a quick little update: I was able to reproduce one crash, it happened after killing the Helicopter while Napalm was disabled, like Rob Dempley had mentioned. This is the only way I've been able to get it to crash, and in this case, I'm 99% sure it's a Rust issue that's just being triggered by HeliControl when it attempts to kill/extinguish the fireball, because the method of removing the fireballs hasn't been changed in a while. I'll look to see if there's a way around this.

 

Interesting... I saw something I'm not familiar with in that log I posted that referenced to things not being properly destroyed.

Entity is NULL but is still in saveList - not destroyed properly? oilfireballsmall[3602199]
Entity is NULL but is still in saveList - not destroyed properly? oilfireballsmall[3602205]

Lines 4737 and 4739 int he log.

 

I just set the amount of water required to extinguish to 500 to give the players a little extra work to do. Can't make it too easy.

Thanks, Shady

 

Shady757 updated HeliControl with a new update entry:

1.1.2

 

Awesome!
[DOUBLEPOST=1483313533][/DOUBLEPOST]Confirmed - works great.

Thanks!

 

Thanks Koenrad,

I've updated my server and will let you know results. I really appreciate you being on top of this.

 

Crashed with latest version - not sure if 100% related to HeliControl as I was removing a base with ent kill at the time.

Code:

========== OUTPUTING STACK TRACE ==================0x00007FF7EC582FDB (RustDedicated) RuntimeSceneManager::GetSceneCount
0x00007FF7EC846B86 (RustDedicated) MeshFilter::GetSharedMesh
0x00007FF7EC446864 (RustDedicated) GameObject::ActivateAwakeRecursivelyInternal
0x00007FF7EC446905 (RustDedicated) GameObject::ActivateAwakeRecursively
0x00007FF7EC446C5B (RustDedicated) GameObject::SetSelfActive
0x00007FF7EC7A573F (RustDedicated) Mesh::GetRuntimeMemorySize
0x0000000017850A9B (Mono JIT Code) (wrapper managed-to-native) UnityEngine.GameObject:SetActive (bool)
0x0000000015B5164B (Mono JIT Code) BaseNetworkable:DoServerDestroy ()
0x0000000015B50AFF (Mono JIT Code) BaseEntity:DoServerDestroy ()
0x0000000015B4DF71 (Mono JIT Code) BaseNetworkable:DoEntityDestroy ()
0x0000000015B4DA83 (Mono JIT Code) BaseNetworkable:Kill (BaseNetworkable/DestroyMode)
0x000000002E1464AF (Mono JIT Code) ServerGib:RemoveMe ()
0x000000000495807B (Mono JIT Code) (wrapper runtime-invoke) object:runtime_invoke_void__this__ (object,intptr,intptr,intptr)
0x00007FFB0A2E503F (mono) mono_set_defaults
0x00007FFB0A238385 (mono) mono_runtime_invoke
0x00007FF7EC6C554D (RustDedicated) ScriptingArguments::AddString
0x00007FF7EC6C5831 (RustDedicated) ScriptingArguments::AddString
0x00007FF7EC61A515 (RustDedicated) IIMGUI::IIMGUI
0x00007FF7EC62CD00 (RustDedicated) ScriptingManager::RebuildClassIDToScriptingClass
0x00007FF7EC4DF659 (RustDedicated) Behaviour::InitializeClass
0x00007FF7EC696D58 (RustDedicated) CallbackArray1<bool>::Invoke
0x00007FF7EC752C70 (RustDedicated) Append
0x00007FF7EC7535BA (RustDedicated) PlayerMainWndProc
0x00007FF7EC75674D (RustDedicated) PlayerWinMain
0x00007FF7ECC0DEAC (RustDedicated) RectT<int>::GetBottom
0x00007FFB22518364 (KERNEL32) BaseThreadInitThunk========== END OF STACKTRACE ===========

 

Hmm, hard to say for sure. At the end of the day, the error still lies in Rust, something recently changed with either the way entities are spawned/killed. Delaying the kill just a little bit after the spawn seems to be (at least somewhat) the fix. The stack trace isn't all that useful, as it could be anything using .Kill. Do you perhaps have another plugin that disables something, e.g. killing it when the hook OnEntitySpawned is called?

 

Nah, nothing that interferes with the OnEntitySpawned with Heli's. Do you know how to look into the IsDestroyed hook? as there was a big change there, not just the rename.

 

It's not just Helicopters. It's any entity from what I can tell, in the case of HeliControl it was just the 3 things that were killed (if the config enabled so); fireballs, gibs, and the heli itself. Any plugin that kills an entity as soon as it spawns *could* be causing it, but don't go around blaming other plugins immediately, just test them.

I don't think I ever actually looked at what IsDestroyed did originally (lol), so I'm not sure what the change is.

 

Ah, pretty sure none of my plugins function in a way that it would destroy entities as soon as they're created therefore I never crash - However as soon as I enabled heli's I get crashes which is probably due to the fact that some entities from the heli at times would get instantly destroyed.

afaik the only change that would be causing this is the IsDestroyed change. As I have been in an ongoing conversation with Alistair he mentioned that IsDestroyed was a big change in which he commented "Not too surprising if its crashing."

 

Damn... just had a crash. The crash occurred the second they finished mining the helicopter. To note, they had taken down 10+ helis without mining it... I've honestly never mined a heli so apologies for this explanation. Dodds mined the landing strip with a light each time and it crashes.

Since my server has far more heli's that other servers (once ever 45 minutes) we run into this issue more.

Any thought son this?

 

If it's crashing after they harvest the gibs, then it's probably a Rust issue. There are only 3 instances where the plugin does anything to the gibs, that is when they are disabled, have a health value other than 500 (default), or are set to be harvestable at a duration other than 480 seconds. I highly doubt any of those are causing the crashes.

 

Go to the rust root directory, open the folder named with today's date then open output_log.txt and paste the stacktrace here (end of the file)

I wanna compare them.

Best thing you can do for now is just fully disable helicopters, remove Helicontrol & keep heli.lifetimeminutes 0