The Grand Exchange

Ok, first off you rock. I love this mod (and the bounty hunter one). It has added a whole different level to our server. We have only had 2 or 3 small problems.

First one.

On this one I am not sure if it is the mod or the game at fault. I have set the max gold from pve to 500, and if someone used a regular weapon that is the max they can get. The problem is that if they use the whip they can get up too (if not more) 3000 gold. The dead animal doesn't go away because the damage on the whip is so low. Not sure if that can even be fixed.

Number two.

We have these random animals that popup and do one hit kills on people (even crabs). It is not all of the animals; just a few. This isn't a game breaker, and adds a little excitement to the mix. But, some of the players have been complaining about it (hasn't stopped them from earning gold though).

Number three.

This is the one I want to bring to your attention. When someone puts down a treb it can't be destroyed. They can sit and hit on it for hours (as a few people have done), and just get stacks gold from it. It will never go away, and never reach a gold cap.

I know this problem is because of this mod because if I unload it the problem isn't there anymore. People can destroy a treb just fine. I have looked through the files, but can't find anything in there that could fix this.

So I am sending a message to you in hope that you will know how to fix this. It is the only real exploit that I can find that people are abusing.

Beyond that I have nothing but good things to say about this mod (now that I understand how it work .. kinda). And I hope you might look into a request I have made in the forums about crests.

Thank you for your hard work, and the time you put in on this.

***Edit***

I forgot to mention a couple of things I would love to see you add:

1: A back page button in the store popup.
2: The ability to put up multiple locations (it could sell different items or the same ones in each). I have people who get tired of running across the map to get to the store. To have a location on each side would be great.

 

I would love to get a list of permissions so that players can use the /checkcredits commands

 

Hi, Amyen
Thanks for the feedback! Some good bug reports and ideas.
I'll jump onto fixing the bugs first as a priority - I think that the trebuchet thing might be because the game classes a treb as both a monster and a placed entity. (Wtf?)
So I'll add a hook that prevents getting gold from this and the Ballista (which I assume would also be the case).

I have no idea about the animal spawning thing. There's nothing in the code that spawns creatures (I dont think that's even possible at the moment?). And I don't do anything with creature damage amounts.
Do you have any other mods running that affect damage etc?

In any case, will get what I can sorted.

The one thing I can say for the moment - I'm limited in terms of what popup interfaces are available. The only one I have that I can use has two buttons. So if I add a back button (which is pretty simple), it would mean losing the "Exit" button. Which isn't a disaster, because you can still press escape. But I guess it depends on what people prefer.
[DOUBLEPOST=1434613307][/DOUBLEPOST]

Do you mean you want a permission added that allows players to use this?
Rather than adding a whole new permission, I can add a toggle command - something like /checkcreditsrequiresadmin
That way if you toggle it off, then all players can use it.
(Much simpler than messing about with permission)

 

Scorpyon updated The Grand Exchange with a new update entry:

Fixed - No Trade Area Sieging

 

Looking through the code I have some suggestions and possibly fixes I might want to submit, what would be the best way to do that. My knee jerk reaction is to send them as a diff file but that might be a tad too old school
[DOUBLEPOST=1434628890][/DOUBLEPOST]As to the 'farming' issues, one quick fix I can think of is to get an ID number of the object (each object no doubt has a unique ID) being damaged (and farmed for gold) and store that along with a timestamp (datetime.now) in a collection,array, whatever.

First time the object gets hit (after death) the plugin checks if it is in the collection already (which it isn't) : Gold drops and the entity is added to the collection.
Subsequently when the same object/entity is hit again, it is found in the collection and a check is done to see if the last hit to this entity was (for example) less than 5 minutes ago (configurable) and if it was, no additional gold drops.
If the entity was found in the collection but the last recorded hit is older than 5 minutes, gold drops again but the timestamp is updated with the current datetime.now

This would allow people to only get gold from the same entity/object once every 5 minutes in short. That should fix most of the 'abusive' farming. Even the plague villagers (who despawn automatically).

The only issue might be that this list could get large, though not excessively so I would think.

 

You can always private message them to me, etc.
Or email them (Ask me in a PM for my email).
Any help tidying things up a bit is appreciated. Files get a bit hard to manage as they grow.

I'll take a proper look at the farming aspect soon, as this is something I want to flesh out more.
In the meantime, big update on the way...

 

Ok in that case I will wait a little. I would have to start over afterwards anyway

 

Thanks for the responce. The animal one hitter isn't really a problem with me. I kind of like it. Makes it a little more interesting. You can't just carry a block around and kill things over and over again. You never know if you will get a normal one or a monster one. I do have multiple other mods running, so it might be part of the raid boss mod combined with the exchange. It didn't start until I installed them. It doesn't seem to happen when the store mod gets unloaded. Either way I don't care, I like them. It was just something I wanted to bring to your attention.

I will ask the people on our server if they want the exit or a back button. I only asked because it was a little trying when setting the prices to have to exit out and open the store back up. Not a problem now that everything is set

**btw .. you know the bone longbow, the executioners axe, and the masks are not on your list. You have to add them to the default list (in the cs file) in order to add them to the store.**

I just hope putting the hook on the trebuchet will allow it to be destroyed. I had about 6 or 7 on the island that I had to shut the store down, and then destroy for people. This also might be a glitch in the game and the unpacking system they put in. Seeing as it happened once before on the first day of the map. We had no mods installed at the moment and was testing things out. Placed a treb to see how long the unpacking time was. After that we couldn't pick it up, and only could do no damage to it. I think that is part of the problem. So it is another exploit that people jump on. As they always jump on exploits (they can't play like normal). But that is life I guess.

Once again Thank You very much, and keep up the good work.

 

So, are you saying that there was a problem with the Trebs even without any of the plugins installed?
Bit confused by this paragraph.

 

It was a one time thing that hasn't happened again when mods are unloaded. I just thought I would mention it though.

The other night when I was working on the store we had a war going on between 4 different guilds (lots of trebs on the map), and everything was going fine.

A few minutes after I loaded the mod everyone started sending me messages saying that they couldn't destroy the trebs, and some said that they couldn't even pick them up. I was forced to unload the mod, and then they could destroy / pick them up just fine. Not sure if it is happening to just my server.

 

Hmmm. Ok, sounds like it might need some focused testing on this specific issue to make sure there's no actual weirdness.
It "could" just have been that the server needed a restart, but hard to say.
I'll be looking into this tonight.

 

Thank you. For everything. I'm not sure if the destroy / pickup problem is mod or game (or a mix of multiple things). We had one treb on the land for 3 (real life) days.

I can go remove them later. This isn't really my problem. My problem is people exploiting the system and getting millions of gold. So the solution you put first sounds perfect for this issue. If they can't get gold from a treb they will not be able to exploit the problem.

May not fix everything, but will make them have to look for another exploit and allow me a few minutes to build my own place.

 

I just tried that on the server I am on (hitting a treb), and got no gold.

 

Humm .. well thats odd. I will triple check everything when I get home, and update everyone on the situation. I will uninstall every pluhin except the store if I have too .. lol

 

This is brilliant, can't thank you enough Scorpyon.

One issue I'm running into though is that pvpgold, pvegold, and the safetrader command all seem to reset when I restart my server. I have the PVP, PVE gold options turned off, but after every restart they're on again. Safetrader, which is so brilliantly useful, is turning itself off during the restart.

Is it possible to select these options permanently? Or am I the only one having an issue?

 

You have to change it in the cs file (in plugins) .. it is right at the top.

 

Ah, I see it now, I must be blind.

Thank you Amyen.

Being able to designate a safe zone is such an amazing addition. If this plugin did nothing else beyond that it would still be outstanding.

 

Oh yeah. I have my store (Wal-mart) set so that as long as you are inside the doors you can trade and cant be hurt .. the first night I had it up and running I had people waiting around and killing people right after they got something. . Safe trade is awesome.

 

Yea, I had told everyone it was safe and then logged out for the night. Bloody mayhem after the first auto restart. Hah, whoops.

This plugin is truly game changing. Once players can exchange gold between each other it will really be a fully functioning economic system. It's really outstanding work.

 

Lol .. similar with me, but with the added part of me forgetting to set prices. I came back on in the morning to find that everyone on the server had about 30k t7 blocks .. yeah .. everyone had huge bases and caused the server to crash. I couldn't even leave my base without lagging out. Was forced to wipe later that day.