BGrade

Just chiming in that as of 3:13 pm (eastern) today, I've downloaded the most recent version of the plugin and it *does not work* as intended. You can activate/use bgrade inside of building blocked areas.

 

CTRL + F "player.CanBuild()" and whatever is after it remove.

For example the 2 things you would need to change in the plugin are:

Code:

if (!player.CanBuild() && !HasAnyPerm(player)) return;

(there are 2 uses of the one above)

and

Code:

if (!player.CanBuild() && !HasPerm(player, "all") && !HasPerm(player, args[0])) {
                            SendReply(player, GetMessage("BGRADE_NOPERM", steamId)); return;
                        }

You want to change the first one to:

Code:

if (!player.CanBuild()) return;

and the 2nd one to:

Code:

if (!player.CanBuild()) {
                            SendReply(player, GetMessage("BGRADE_NOPERM", steamId)); return;
                        }

This is what I did and it seems to work for me.

 

Would rather just have the plugin updated and supported by developer.

 

I won't be fooling around with the innards of the plugin, I've never had any luck with that. Thank you for all you do, plugin developers !!!

 

That's fine, I'm sure either @Wulf or the original developer will update to fix it soon.

 

Hmm, it seems indeed, there should || (or) instead of && (and) in this two (three?) lines. As right now it check if "player can't build AND don't have permission to build"

Someone test this version, if it works fine then i'll update bit later plugin (or wulf can also do this)

 

This version seems to work as intended ty

 

+1. Working well for me. Might be nice to make a change to the error message to specifically call out why they can't upgrade, but that's just a nitpick. If you have a repo I'd be happy to make a PR for it.

 

I think he meant if they tried to upgrade the twigs or build using Bgrade in an area they aren't supposed to. Like I can raid with twigs, but if I put up stone, it gives an error and tells me.

 

Code:

Failed to run a 30.00 timer in 'AutoGrades v0.0.13' (KeyNotFoundException: The given key was not present in the dictionary.)
at System.Collections.Generic.Dictionary`2[System.String,Oxide.Plugins.AutoGrades+PlayerGrades].get_Item (System.String key) [0x00000] in <filename unknown>:0
at Oxide.Plugins.AutoGrades+<UpdateTimer>c__AnonStorey0.<>m__0 () [0x00000] in <filename unknown>:0
at Oxide.Core.Libraries.Timer+TimerInstance.FireCallback () [0x00000] in <filename unknown>:0

 

@Wulf i looked code and you removed four important lines from "OnServerInitialized" when cleanup code from old code.

Code:

  if (LoadDefault || Config["Block Construct and Refund"] == null || gperm) {
  permission.GrantGroupPermission("admin", "autogrades.all", this);
  permission.GrantGroupPermission("admin", "autogrades.nores", this);
  }

(should be without "|| gperm" in new version)

This lines actually add default permissions on first plugin install (for admins), without them this plugin will do nothing if install it on fresh server. Not sure if this is good or bad, but originally it was made just for admins) Anyway thanks for update, i just don't have much time right now to do it myself.

Yes we can do this, but like wulf said - what message you want to display? I'll do this later in both languages (en/ru).

@Suslik When this happens?

 

@Wulf not sure actually, right now description just saying that "By default works only for admins with no resource consume (only wood for twig part), but you can change that via oxide permissions.", i can just update it to something like "You need assign permissions manually to use this plugin" or so. But as i said originally it was made for admins only) So you can install it and use as admin without configure anything else.

 

I'll take a closer look and get back to you on this ASAP. RE: the automatic granting to admins, I prefer that behavior but it's not much trouble to manually grant them so I'll stay neutral