Trouble modifying Kits plugin with permissions

Discussion in 'Rust Development' started by Twistedwheel, Apr 21, 2016.

  1. Wulf

    Wulf Community Admin

    Add the same permissions checks later where the actual chat commands are called.
     
    Wulf, Apr 24, 2016
    #41
  2. Twistedwheel

    Twistedwheel

    The original plugin by Reneb checks them where I am checking them.

    Code:
                        case "give":
                        if (!hasAccess(player)) { SendReply(player, "You don't have access to this command"); return; }
                        SendReply(player, "/kit give PLAYER/STEAMID KITNAME");
                        break;
    I've recoded it before to work on different auth levels (auth 1 can access "player" and "admin" commands but not "owner") and auth two can access all. Coded it the same way as the one I'm trying to make work but it actually worked.
    [DOUBLEPOST=1461518539][/DOUBLEPOST]Think you could have another look at it and tweak it? At this point I'd happily pay for the fix.
     
    Twistedwheel, Apr 24, 2016
    #42
  3. Wulf

    Wulf Community Admin

    The original plugin doesn't use full permissions, the example you keep showing me is just for the help text from what I can tell, not the actual usage of the command.. I'll take a look Monday most likely, I'm not able to access much right now.
     
    Wulf, Apr 24, 2016
    #43
  4. DylanSMR

    DylanSMR

    So im not sure whats really going on here. But the usage of a give command using kits could be done as so:
    Code:
    [PluginReference]
Plugin Kits;  Kits?.Call("GiveKit", player, "KITNAMEHERE");
     
    DylanSMR, Apr 24, 2016
    #44
  5. Wulf

    Wulf Community Admin

    This is a modified version of Kits. There's no need to call the other Kits plugin when this is the same plugin. The OP is trying to add permissions from what I can tell, that's about it.
     
    Wulf, Apr 24, 2016
    #45
  6. DylanSMR

    DylanSMR

    Ohhh ok!
     
    DylanSMR, Apr 24, 2016
    #46
  7. Twistedwheel

    Twistedwheel

    Did you get chance to take a look? Had another dev look at it and they can't find an issue.
     
    Twistedwheel, Apr 25, 2016
    #47
  8. Wulf

    Wulf Community Admin

    I've mentioned the issue a few times from what I see with it, there are no permission checks being done on the actual commands.
     
    Wulf, Apr 25, 2016
    #48
  9. Twistedwheel

    Twistedwheel

    Don't suppose you'd rectify that? No idea how to. I'd happily compensate you for doing it...
     
    Twistedwheel, Apr 25, 2016
    #49
  10. Wulf

    Wulf Community Admin

    I'll test in see in a bit.
     
    Wulf, Apr 25, 2016
    #50
  11. Twistedwheel

    Twistedwheel

    Did you have a look? Sorry for the spam!
     
    Twistedwheel, May 1, 2016
    #51
  12. Twistedwheel

    Twistedwheel

    Just curious as to whether this got looked at in the end? Didn't end up putting any more time into it as I couldn't figure it out.
     
    Twistedwheel, May 16, 2016
    #52
  13. Wulf

    Wulf Community Admin

    Hey there, I actually lost the thread and couldn't find it. :p

    I'll try to get back to you shortly.
     
    Wulf, May 16, 2016
    #53
  14. Twistedwheel

    Twistedwheel

    Haha, no worries! and thank you.
     
    Twistedwheel, May 17, 2016
    #54