The Grand Exchange

I haven't had time to read through your code but does your plugin have a global economy limit of cash? Or is the economy infinite in size just each player can only possess Max Int value.

 

Iiiinteresting.
I haven't had a chance to test the GE on A16 yet on my test server.
Will try and do so tomorrow.
[DOUBLEPOST=1435449721][/DOUBLEPOST]

It simply limits the amount of cash a player can accrue.

 

Maybe this is just me but, wouldn't it make more sense to have a max global gold count. Then gold is distributed throughout the server by means of selling resources to the exchange? Kind of like a real economy where there is a limited amount of money.

 

Hello, thanks for you plugin. I have a problem with /pvegold and /pvpgold, settings reset to on after restart.

 

Many people miss your plug-in on my server, but it still makes raid equipment not work.

 

I'm working on trying to get this fixed for you right now.
Am trying to work out where the problem lies.
[DOUBLEPOST=1435563452][/DOUBLEPOST]Tatosoup, do you have a marked out area for the GE?
If not, can you try using /markremoveall

This is in case the trebs are being prevented by the safearea bit of code.
If that fixes the prohlem, then I think I know what is going on and can fix it.

 

my Savedmarklist.json contains no coords, only [] i will try removing that when im home from work.

 

Code:

9:23 AM [Debug]   at Oxide.Plugins.GrandExchange.OnCubeTakeDamage (CodeHatch.Blocks.Networking.Events.CubeDamageEvent cubeDamageEvent) [0x00000] in <filename unknown>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)

 

Upperking seems to have the exact error.

 

Thanks UK!
Really wish this error gave a little more hint as to the problem. :/
I'll keep scouring the code and logs.

 

Having an issue with changing the price of items via the command /setprice "stone block" 1300 is the command i use but no luck.

 

Hmm.
Are you having the same problem with any other price setting?

As a possibility, check if it's a capitalisation problem:
/setprice "Stone Block" 1300

Another idea - also try with another price, such as:
/setprice "Stone Block" 2000

There was a strange bug a loooong time back where for some weird reason, some prices just wouldn't take. I really don't know why, but it disappeared after a while. Wondering if this might have reared its ugly head again.

Lastly, any log errors?

 

Still just 1 error from the grand exchange I don't think it is related to the store it's self though looks similar to the war tracker error regarding cube damage...

Ok checked logs and can;t seem to find that error anymore however found a new one which i haven't noticed before.

Code:

2:17 PM [Error] Failed to call hook 'GiveGold' on plugin 'Grand Exchange' (ArgumentException: failed to convert parameters)
2:17 PM [Debug]   at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x00000] in <filename unknown>:0
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hookname, System.Object[] args) [0x00000] in <filename unknown>:0 

Also tried suggested commands but no luck.

 

Ah I know what will be causing this - though its not a big error.
It's basically that someone has tried to call this command and (probably) forgotten to put the name in quotes (or typed two numbers oat the end - or something to that effect.
Shouldn't cause any major issues, but I'll put some checks in for that shortly

 

Also there is the issue of pvegold not staying off even when i turn it off it reactivates itself on restarts?

 

Another issue is with players setting up shopmarkers. I do not know if it is intentional but as soon as someone sets up a playershop area the /buy command stops working outside of that area even if no specific area was set for the serverwide /store itself. Subsequently using /removeshopmarkers does not fix the issue and /buy continues to only work in the shoparea.

This does not sound like the desired behaviour to me. One would like to set up the /store serverwide (no area limitation) with relatively 'crappy' prices (as a last resort store option) so that players can set up their shops in local areas with more competitive prices.

 

Hmm. I don't think the option variable is being saved by the sound of it.
Ok, cheers!

I've noticed this issue. Not sure yet what's causing it, but I have discovered that using
/markremoveall temporarily fixes the issue.

 

Hey scorpyon,

Really nice mod! Thanks!

I have a slight problem with the PVP gold...

When a player is guild is says something along these lines as "This player had no gold", when infact they did...

Not too sure how to fix it.

I will upload my file

cheers,

 

Is the player in the same guild?
If so, then you aren't allowed to get gold from them.
However, if that's the case and you are seeing the above message, this sounds like it's a small bug showing the wrong message for this case.
Can you confirm?
If the above is what happened, it should be an easy fix.

 

Yeah i can confirm that they werent in teh guild... i've attached the file and i cant see anything wrong