Vote Checker & Rewarder [Unmaintained]

/getreward is now broken and doesn't say anything to the player, tested on two different servers and no message is shown.

Tested with both players who voted and players who did not, no error is produced and I tried with a vanilla config.

Looks like there are no messages in the plugin anymore to throw errors like the contact an admin error used to popup?

 

So it's still broken? You disabled messages so now we have no way to know what's going on. Please take the time to fix this properly it's very annoying to have it broken and "fixed" to find it broken just to piss more people off when I tell them you fixed it.

 

Why are you saying it's broken? Also upload your config file.

 

Pho3nix, if you run it on a clean server with completely clean config and settings, then login or type /getreward nothing shows up, and when you go to vote and then try still, nothing happens. No message, nothing.

 

Uh I'm saying it's broken because anyone who votes after I updated this with your newly recent 2.1.5 update does not receive any rewards or any messages to explain that they did not vote or contact an admin. So how's it not broken if they are not receiving the rewards? That's the point of this right?

 

Did you edit configs manually or via command? I have tried all scenarios and everything is fine on my side.
[DOUBLEPOST=1455051051][/DOUBLEPOST]

Upload your CONFIG file.
Yes true, but there is no way for me knowing what your reason is for saying "it's not working" without giving me an explanation. And doing so with an attitude will get you nowhere.

 

I am using clean configs, I literally deleted every file from the server, setup server as new, installed your plugin, no messages. Also tried it on existing server with configs and same thing, no message. Before your latest fix I patched it myself and fixed the error with giveItems and it at least gave messages, with your latest fix it doesn't even show messages but also doesn't error.

 

Alright I see.

Could you send me your config file, user file, rewards file either on here or via PM for me, so that I can try and source why this error is not going away.

 

Here's the config. I tried both Listforge and your list.

3:00 PM [Info] [VoteChecker] http://api.cyberscene.co.za/listfor...mode=month&interval=weekly&platform=hurtworld
3:00 PM [Error] [VoteChecker] Game-Servers.top Error: '<br />
<b>Fatal error</b>: Call to a member function fetch_object() on a non-object in <b>/home/tqpnxrsw/public_html/api/query.php</b> on line <b>66</b><br />
' - Slongdong didn't received their reward.

 

Thanks.

Okay the problem I see right of the bat is the following:
"trackingInterval": "weekly",
"trackingType": "month"
The interval should be an integer, meaning 1.
So if the interval is 1 and type is month, it will check the votes for the last month, if interval was 2 it would check all votes from now until 2 months back.

I will add a check to make sure users pass a integer.

Please fix that mistake and let me know.
[DOUBLEPOST=1455052681][/DOUBLEPOST]

Also, the game-servers.top api is wrong, you punched in the api from listforge.

 

@Pho3niX90
Love the Plug-in.
Only issue I noticed was recently.
I voted on both sites linked and gained 2 votes bringing me from 8 votes to 10, in return it gave me my reward for the 10th vote but not the 9th.

 

what is the TGSaddress and TGS api ? Where would I find that?

 

Home - Top Game Servers
^Click
Once you register your server, go to "Account" at the top of the screen then "My Servers" on this page your tgs api key can be found.

 

Aah I see.
Okay I will have to make it that it gives rewards for all missed votes then. Originally i did not want to do it to force users to login and claim prizes, instead of stockpiling votes. But I get now it will have to.

 

Pho3niX90 updated Vote Checker & Rewarder with a new update entry:

2.1.5D

 

So your Debug text breaks the plugin now.:

Code:

void giveItems(PlayerSession player, int voteCount)
        {
            Debug(1, "Votecount passed to giveitems is " + voteCount);
            var playerName = player.Name;
            var playerId = (ulong)player.SteamId;            var RewardsLimited = from p in Rewards.ToList() where p.votesRequired == voteCount || p.votesRequired == -1 select p;
            var tmplastVote = Users.Where(d => d.steamid == playerId).FirstOrDefault();
            Debug(1, "The lastvotecount before checks is " + tmplastVote.lastvote);
            if (tmplastVote == null)
            {

You try to output tmplastvote.lastVote before checking if tmpLastVote is null. Please test before uploading it seems like every single time this is updated another major feature breaks.

 

16:49 [Debug] at Oxide.Plugins.VoteChecker.giveItems (.PlayerSession player, Int32 voteCount) [0x00000] in <filename unknown>:0
at Oxide.Plugins.VoteChecker.WebRequestCallback (Int32 code, System.String response, .PlayerSession player) [0x00000] in <filename unknown>:0
at Oxide.Plugins.VoteChecker+<GetRewardsForThisPlayer>c__AnonStorey3.<>m__1 (Int32 code, System.String response) [0x00000] in <filename unknown>:0
at Oxide.Core.Libraries.WebRequests+WebRequest.<OnComplete>m__1 () [0x00000] in <filename unknown>:0




i dont now... but is it possible that /getrewards is in the wrong ChatMessage server?

 

Pho3niX90 updated Vote Checker & Rewarder with a new update entry:

2.2.0

 

On the first save I used it for, it worked perfectly. I've kept this plugin updated throughout but I've had a hell of a time getting it to reward everyone properly since wiping. Even when I hit clear player data it does not seem to like to reward people who have already voted before. I reward people for their 1st vote and every 10 votes after that. Seems like it never registers votes from people who have voted on previous save. In fact it has not rewarded myself since that first save state.

Note - I have even tried completely deleting it, fresh install. And I do have the API and ID in the config file.

Also, I am either an idiot or it is unclear to me what exactly the "tracking interval" or "tracking type" functions do. Is this the interval between checks, or the interval between counted votes? I just changed it to "1" and then "minute" in hopes this resolves my issue

 

Pho3niX90 updated Vote Checker & Rewarder with a new update entry:

2.2.1

[DOUBLEPOST=1455479405][/DOUBLEPOST]

The tracking interval is for which period it should "report" votes. For example
1 week, it would show votes for the past week. 1 month, for the past month ect. minute is not valid and won't work, so it would go to a failsafe of lifetime tracking. If you keep getting the error please send me all files related to the votechecker plugin and pm it to me. I do not always get notifications from these threads.
[DOUBLEPOST=1455479531][/DOUBLEPOST]

Thank you. And you are right. Was fixed though. It is sometimes hard to test a plugin to the fullest, with other words. All possible scenarios. This is why after the plugin works I will not be updating it anymore.