Solved Identity returning null in OnPlayerDisconnected (pirated servers, unsupported)

Discussion in 'Hurtworld Development' started by SannyOK, Dec 14, 2015.

  1. SannyOK

    SannyOK

    Hello @Wulf! Why with latest update hook broken? OnPlayerDisconnected returning null!
     
    SannyOK, Dec 14, 2015
    #1
  2. Wulf

    Wulf Community Admin

    How is it returning null? I can't really tell you what is wrong without details of what you are doing.
     
    Wulf, Dec 14, 2015
    #2
  3. SannyOK

    SannyOK

    For example:

    void OnPlayerDisconnected(PlayerIdentity player)
    {
    Debug.Log(player.Name)
    }

    Later it was returning PlayerIdentity, now - null.so the code in body not working and creating errors.
     
    SannyOK, Dec 15, 2015
    #3
  4. Wulf

    Wulf Community Admin

    I have plugins using that just fine. Can you provide a full example of your plugin?
     
    Wulf, Dec 15, 2015
    #4
  5. SannyOK

    SannyOK

    Code:
    [HookMethod("OnPlayerDisconnected")]
void OnPlayerDisconnected(PlayerIdentity player)
{
if (player.IsAdmin)
{
ulong playerID = player.SteamId.m_SteamID;
if (!adminToggle.ContainsKey(playerID)) return;
adminToggle[playerID] = false;
return;
}
}
    Before update everything was working. Right now player returns Null.
     
    SannyOK, Dec 15, 2015
    #5
  6. Wulf

    Wulf Community Admin

    Try with the upcoming snapshot.

    Also, you don't need [HookMethod("OnPlayerDisconnected")] and you can get the Steam ID with player.SteamId, you don't need m_SteamID.
     
    Wulf, Dec 15, 2015
    #6
  7. Steiron_

    Steiron_

    Hi, same problems

    void OnPlayerDisconnected(PlayerIdentity player)
    {
    Interface.Oxide.LogDebug(player.Name);
    }
    Code:
    10:12 PM [Debug] at Oxide.Plugins.Tested.OnPlayerDisconnected (.PlayerIdentity player) [0x00000] in <filename unknown>:0
at Oxide.Plugins.Tested.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00000] in <filename unknown>:0
at Oxide.Plugins.CSharpPlugin.InvokeMethod (System.Reflection.MethodInfo method, System.Object[] args) [0x00000] in <filename unknown>:0
at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x00000] in <filename unknown>:0
at Oxide.Core.Plugins.Plugin.CallHook (System.String hookname, System.Object[] args) [0x00000] in <filename unknown>:0
     
    Steiron_, Dec 15, 2015
    #7
  8. SannyOK

    SannyOK

    I'm using extension and without hook everything doesn't works.
     
    SannyOK, Dec 15, 2015
    #8
  9. Wulf

    Wulf Community Admin

    What are you doing that needs to be in extension format? Plugins should be able to handle pretty much anything you need generally.
    [DOUBLEPOST=1450160267][/DOUBLEPOST]
    As I mentioned previously, try again with the latest Oxide snapshot, build 2.0.1639 or higher.
     
    Wulf, Dec 15, 2015
    #9
  10. SannyOK

    SannyOK

    I'm using extension to make my plugins private. :p
     
    SannyOK, Dec 15, 2015
    #10
  11. Wulf

    Wulf Community Admin

    Plugins can be private too, just don't publish them. You're losing some useful development features such as hotloading by doing it as an extension vs. just a plugin. Is there something specific you actually need that can't be done via a plugin?
     
    Wulf, Dec 15, 2015
    #11
  12. SannyOK

    SannyOK

    It's my choose how to do this... :)
     
    SannyOK, Dec 15, 2015
    #12
  13. Wulf

    Wulf Community Admin

    Okay, just saying you're just making things more complicated for yourself. ;)
     
    Wulf, Dec 15, 2015
    #13
  14. SannyOK

    SannyOK

    Just tell @dcode to make his RusIO like a plugin....

    Maybe better to fix some problems with hook? :)
     
    SannyOK, Dec 15, 2015
    #14
  15. Wulf

    Wulf Community Admin

    There's a difference between his and what you've shown me so far... What his extension does is not possible via plugins, as Oxide doesn't provide a built-in web server nor does it provide web sockets. Does your extension use either of those?

    As I said previously as well, the hook should be fixed in the upcoming snapshot.
     
    Wulf, Dec 15, 2015
    #15
  16. SannyOK

    SannyOK

    Okay, will try. Thanks.
     
    SannyOK, Dec 15, 2015
    #16
  17. Steiron_

    Steiron_

    Nothing changed

    Code:
      void OnPlayerDisconnected(PlayerIdentity identity, uLink.NetworkPlayer player)
        {
            Interface.Oxide.LogDebug(identity.SteamId.ToString());
        }
    [DOUBLEPOST=1450173197][/DOUBLEPOST]
    Code:
    void OnPlayerDisconnected(PlayerIdentity identity, uLink.NetworkPlayer player)
        {
            if (identity != null)
                Debug.Log("Work!");
        }
    [DOUBLEPOST=1450191708,1450172948][/DOUBLEPOST]Ohh... same problem with OnPlayerRespawn hook
     

    Attached Files:

    Steiron_, Dec 15, 2015
    #17
  18. SannyOK

    SannyOK

    Tried again and nothing...
     
    SannyOK, Dec 15, 2015
    #18
  19. Wulf

    Wulf Community Admin

    I can't reproduce it. With my tests the identity is working 100%. All I can suggest is making sure you are using Oxide 2.0.1637+ and to do some null checks. We don't provide the identity, we just pass it along.
    Code:
    void OnPlayerConnected(PlayerIdentity identity) => Puts(identity.Name + " " + identity.SteamId);
void OnPlayerDisconnected(PlayerIdentity identity) => Puts(identity.Name + " " + identity.SteamId);
    b409df742dd0fb8cbd06621a57fa9246.png
     
    Wulf, Dec 15, 2015
    #19
  20. Steiron_

    Steiron_

    I don't know...
    Code:
    void OnPlayerDisconnected(PlayerIdentity identity) => Puts(identity.Name + " " + identity.SteamId);
    [DOUBLEPOST=1450240855][/DOUBLEPOST]
    Code:
     void OnPlayerDisconnected(PlayerIdentity identity, uLink.NetworkPlayer player)
        {
            PlayerIdentity testPlayer = GameManager.GetPlayerEntity(player).GetComponent<PlayerIdentity>();
            if (testPlayer != null)
                Debug.Log(testPlayer.Name + " " + testPlayer.SteamId);
            else
                Debug.Log("uLink Player: " + player.ToString());        }
     

    Attached Files:

    Steiron_, Dec 16, 2015
    #20