Any thoughts or ideas on this plugin

Discussion in 'Rust Development' started by Kappasaurus, Jul 5, 2016.

  1. Kappasaurus

    Kappasaurus

    I just finished the improved version, does anybody have any ideas/improvements I can work on?
    RespawnMessages
    Provide massages players can view on respawn.
     

    Attached Files:

    Kappasaurus, Jul 5, 2016
    #1
  2. Wulf

    Wulf Community Admin

    I'd remove the /rm command, store the config entries in variables instead of calling the config each time it is used, and reduce some of the duplicate code in OnPlayerRespawn by either inline if checking or setting a new message based on that setting.
     
    Wulf, Jul 5, 2016
    #2
  3. Kappasaurus

    Kappasaurus

    Ok I will try to understand that ;)
     
    Kappasaurus, Jul 6, 2016
    #3
  4. Wulf

    Wulf Community Admin

    For the config you can see an example in most of my recent plugins, else perhaps some of Nogrod's.
     
    Wulf, Jul 6, 2016
    #4
  5. Kappasaurus

    Kappasaurus

    Ok, appreciate the help
    [DOUBLEPOST=1467761504][/DOUBLEPOST]
    Wulf do you know if it got declined? It is gone now. :/
     
    Kappasaurus, Jul 6, 2016
    #5
  6. Wulf

    Wulf Community Admin

    You appear to still be working on it, so I didn't approve the old submission with the outdated version yet.
     
    Wulf, Jul 6, 2016
    #6
  7. Kappasaurus

    Kappasaurus

    Well I have a updated version, do I have to reupload it? I thought I had to wait until you approved it to upload the new version. My other ideas I want to add at some point but I need to learn a bit more before doing so.
    (The updated version being the one posted at the top)
     
    Kappasaurus, Jul 6, 2016
    #7
  8. Kappasaurus

    Kappasaurus

    I've re-uploaded it with some changed, a more complete final version, ofc I intend to fix problems if any occur.
     
    Kappasaurus, Jul 6, 2016
    #8