Salvager [Unmaintained]

Deicide666ra submitted a new resource:

Salvager - Allows players to create a Salvage Bench and use it to salvage items

Read more about this resource...

 

seems like this plugin also need an update after todays patching of Rust.

At least not working for me.

 

There's only version 1 of this plugin?

 

Where can I find the current Oxide version info?

Running with a host where I just have to click install latest version, not giving info on which is actually the latest version.

 

2.0.1222.

I can see there's newer version, gonna go check if the host got a new update for Oxide, as I would assume 1226 or 1228 will have it fixed?

on a side note, I couldn't give you any better than not working as nothing was happening, not even log info. Will post follow-up after Oxide update

 

working great now.

Future request though: Show the amount of resources gained by salvage

 

getting alot of 6:26 PM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 983ms and a few other callhooks

also my server is taking a very long time to reload when i have this plugin installed like 15 mins without this plugin it loads in like 4 mins

 

Noted! Sorry for the late reply, for some reason the thread here didn't auto-watch for me so I never knew anyone posted here lol
[DOUBLEPOST=1438376477][/DOUBLEPOST]

This is strange to me. When this plugin loads it does load a bit of data and can take a few seconds to complete, but 11 minutes is way way way above what I'm seeing during my tests here. Just loaded it on my test server to make sure, see for yourself:

[Oxide] 4:59 PM [Info] Salvager was compiled successfully in 1984ms
[Oxide] 4:59 PM [Warning] A plugin has polluted the global namespace by defining SalvagerExtensions: Salvager
[Oxide] 4:59 PM [Info] Loaded plugin Salvager v1.0.0 by Deicide666ra

I also do not get any hook messages while using it at all, so I don't know what's going on. I would venture to say your server is having issues that are not related with this plugin.

 

getting this...laggs the server to death

Code:

[Oxide] 12:48 AM [Warning] CallHook 'OnEntitySpawned' on plugin 'Rust:IO for Oxide' took average: 311ms
[Oxide] 12:48 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:48 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:49 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:49 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 997ms
[Oxide] 12:49 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:49 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:49 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:49 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:50 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 999ms
[Oxide] 12:50 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 997ms
[Oxide] 12:50 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:50 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms
[Oxide] 12:50 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 997ms
[Oxide] 12:50 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 999ms
[Oxide] 12:51 AM [Warning] CallHook 'OnItemAddedToContainer' on plugin 'Salvager' took average: 998ms

also extra note this particular one happened after using /reload but it does this whenever the server restarts as well

 

Thanks for reporting this, it now seems two of you have this issue. I'm going to review the plugin tomorrow, it seems the issue is with that Hook... Just curious, do you run BetterLoot and/or Cornucopia? Give me your plugins list please.

 

better loot yes. it did spam the error directly after betterloot reloaded

 

OK I will do some testing tomorrow, in the meantime, I recommend removing Salvager. I will probably need to optimize the code in the hook, it's probably too much.. Better Loot is pretty intense on refreshing loot containers

 

Deicide666ra updated Salvager with a new update entry:

1.0.1

 

Wulf, thanks for that, nobody reported that it wasn't working and I don't even run it on my server. I reviewed the code and I think you messed up on the change to RemoveItemsFromInventory, I fear this might either remove a random thing, or just plain throw an exception.. The dictionary TryGetValue there is to check if the user has the said item in his inventory and remove it.. You removed the line, so it's calling FindItemsByID with null... It sure won't fetch what it's supposed to!

All that said, I'm not going to persue dev on this one, I have this functionality integrated in another mod that's coming out soon so this one is up for grabs. If anyone wants to keep maintaining it, be my guest!