Solved Multiple plugins working or broken

Discussion in 'Reign of Kings Discussion' started by Sharpstar, Aug 21, 2015.

  1. Sharpstar

    Sharpstar

    Once we updated to v. 2.0.1297 (and beyond) Command Logger has stopped recording commands entirely.

    Looking at those revision notes, I am wondering if the change to hooks may be the cause and how we could work around to fix it. I am sure there are other plugins that are experiencing similar issues that I may not have noticed yet.

    My question is not necessarily about this specific plugin, so much as about what was changed with Oxide and how I can work around that to get it working again. This removes my ability to keep several chat logs that are created by commands as well. It also seems to have impacted how our new Chat plugin works too.

    Is there an easy work around, or perhaps a way of reverting some change in Oxide that may be the cause?
     
    Sharpstar, Aug 21, 2015
    #1
  2. Wulf

    Wulf Community Admin

    The Command Logger issue is an easy one, the plugin is using a hook that is meant for internal-use only. We'll look into a fix for that.

    For the others, I'll have to see.
     
    Wulf, Aug 21, 2015
    #2
  3. Sharpstar

    Sharpstar

    Grand Exchange was working for us in Alpha 19. We developed an all-in-one chat plugin with some cool features. They both worked until we updated Oxide to 2.0.1297.

    Why were these internal hooks taken out? It disabled some of our plugins entirely. We spent a fair amount of time getting the Chat one like we wanted. We have also been without any way to track commands for days. Grand Exchange is down. We had to revert back to other chat plugins and totally disable Grand Exchange for the moment. We are also flying blind on Commands and thus missing command, OOC, Admin Chat, and PM logs. Causing us a lot of problems.
     
    Sharpstar, Aug 21, 2015
    #3
  4. Wulf

    Wulf Community Admin

    The issue with Grand Exchange is the way it creates and reads its config file, which is the case for the other plugins from that particular author. @Nogrod has a fix for those that he'll be posting soon in the threads for those plugins.

    Internal hooks were never meant to be used by plugins, only Oxide's core. Plugins shouldn't have been using them before. If you need a hook, just let us know what you are looking for, and we'll be able to create one that is meant for plugins.
     
    Wulf, Aug 21, 2015
    #4
  5. Sharpstar

    Sharpstar

    I ended up just reverting to a previous version of Oxide so we could get our things working again. I cannot afford for these things to be down any longer.

    That seems to have gotten everything back online like before.
     
    Sharpstar, Aug 21, 2015
    #5
  6. Wulf

    Wulf Community Admin

    I wouldn't rely on it though for future updates. The latest Oxide snapshot should fix the JSON issues, and we'll be adding a replacement hook for Command Logger to use. Internal hooks were blocked to prevent potential issues from overriding them and such, especially with IOnPlayerCommand, as it is vital to Oxide core with RoK.
     
    Wulf, Aug 21, 2015
    #6
  7. Sharpstar

    Sharpstar

    doIOnPlayerChat is what we were using for our Chat plugin to both filter and mute.
     
    Sharpstar, Aug 21, 2015
    #7
  8. Mughisi

    Mughisi

    IOnPlayerChat shouldn't be used actually, a recent change has blocked internal hooks from being used by plugins. Instead you should use the hook OnPlayerChat that is available for plugins. You can just switch out IOnPlayerChat with OnPlayerChat as they work in the same way.

    And regarding the command logger, this was basically the same issue but with a different hook that wasn't present but which has been added in the latest snapshots (build 1311) and the plugin has been updated for this change.
     
    Mughisi, Aug 23, 2015
    #8