Friends can't join my server

I tried port forwarding and my firewall but I still can get my friends to join what should I try to fix it.

 

The are free tools available to check if your ports are forwarded correctly. The best and easiest one I've found is called Simple Port Tester by PcWinTech.com. Download that and check that your ports are actually open, make sure you run it on your server host machine.

 

okay sorry I was gone had to do things but I tried the program with the ports 28015 and 28016 on tcp and udp and the failed what should I do thanks

 

i fixed it it was my modem i didn't port forward right on that